[PATCH] D97749: [flang] Detect circularly defined interfaces of procedures

Tue Mar 2 06:55:08 PST 2021

awarzynski added a comment.

@PeteSteinfeld, thank you for resubmitting https://reviews.llvm.org/D97201, but this is still failing on 6 out 8 our public Flang buildbots:

- http://lab.llvm.org:8011/#/builders/21/builds/9625
- http://lab.llvm.org:8011/#/builders/134/builds/2395
- http://lab.llvm.org:8011/#/builders/79/builds/6298
- http://lab.llvm.org:8011/#/builders/66/builds/2084
- http://lab.llvm.org:8011/#/builders/135/builds/2485
- http://lab.llvm.org:8011/#/builders/32/builds/3551

If I understand correctly, `std::hash` that you use here is implementation-dependent <https://en.cppreference.com/w/cpp/utility/hash> and hence the the expected result in `resolve102.f90` is not 100% deterministic and hence it is not matched on certain platforms.

In D97201 <https://reviews.llvm.org/D97201> I proposed a solution that to the best of my knowledge will work on every platform (I tested it on AArch64). If you prefer a different approach, I'm happy to test it on an AArch64 machine before this is merged. Please could you add me as a reviewer for that? I am very keen to help with this and to make it work on every of the supported platforms.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97749/new/

https://reviews.llvm.org/D97749