[PATCH] D80163: [X86][VARARG] Avoid spilling xmm registers for va_start.

[Pengfei Wang via Phabricator via llvm-commits]

pengfei added a comment.

I had a check on the tests, the changes LGTM.



================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:3490
+        // VASTART_SAVE_XMM_REGS to avoid unneccessary spilling.
+        TheMachineFunction.getRegInfo().addLiveIn(Reg);
+        LiveXMMRegs.push_back(DAG.getRegister(Reg, MVT::v4f32));
----------------
Does the change affect GreedyRA?


================
Comment at: llvm/test/CodeGen/X86/xmm-vararg-noopt.ll:1
+; RUN: llc -O0 -mtriple=x86_64-unknown-unknown < %s | FileCheck %s
+
----------------
Maybe we can also generate the test by update_llc_test_checks?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80163/new/

https://reviews.llvm.org/D80163