[llvm] 949d1d9 - [JITLink] Remove some std::move(MemoryBufferRef) below createLinkGraphFromObject() (NFC)

[Stefan Gränitz via llvm-commits]

Author: Stefan Gränitz
Date: 2021-03-02T15:07:34+01:00
New Revision: 949d1d9937364a18c99bf549a6503285d7e61a5a

URL: https://github.com/llvm/llvm-project/commit/949d1d9937364a18c99bf549a6503285d7e61a5a
DIFF: https://github.com/llvm/llvm-project/commit/949d1d9937364a18c99bf549a6503285d7e61a5a.diff

LOG: [JITLink] Remove some std::move(MemoryBufferRef) below createLinkGraphFromObject() (NFC)

Added: 
    

Modified: 
    llvm/lib/ExecutionEngine/JITLink/ELF.cpp
    llvm/lib/ExecutionEngine/JITLink/JITLink.cpp
    llvm/lib/ExecutionEngine/JITLink/MachO.cpp
    llvm/lib/ExecutionEngine/Orc/ObjectLinkingLayer.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/ExecutionEngine/JITLink/ELF.cpp b/llvm/lib/ExecutionEngine/JITLink/ELF.cpp
index 27eb7d576e2d..3a270d850815 100644
--- a/llvm/lib/ExecutionEngine/JITLink/ELF.cpp
+++ b/llvm/lib/ExecutionEngine/JITLink/ELF.cpp
@@ -65,7 +65,7 @@ createLinkGraphFromELFObject(MemoryBufferRef ObjectBuffer) {
 
   switch (*TargetMachineArch) {
   case ELF::EM_X86_64:
-    return createLinkGraphFromELFObject_x86_64(std::move(ObjectBuffer));
+    return createLinkGraphFromELFObject_x86_64(ObjectBuffer);
   default:
     return make_error<JITLinkError>(
         "Unsupported target machine architecture in ELF object " +

diff  --git a/llvm/lib/ExecutionEngine/JITLink/JITLink.cpp b/llvm/lib/ExecutionEngine/JITLink/JITLink.cpp
index 93dfba9c759b..25b554fcb39e 100644
--- a/llvm/lib/ExecutionEngine/JITLink/JITLink.cpp
+++ b/llvm/lib/ExecutionEngine/JITLink/JITLink.cpp
@@ -327,9 +327,9 @@ createLinkGraphFromObject(MemoryBufferRef ObjectBuffer) {
   auto Magic = identify_magic(ObjectBuffer.getBuffer());
   switch (Magic) {
   case file_magic::macho_object:
-    return createLinkGraphFromMachOObject(std::move(ObjectBuffer));
+    return createLinkGraphFromMachOObject(ObjectBuffer);
   case file_magic::elf_relocatable:
-    return createLinkGraphFromELFObject(std::move(ObjectBuffer));
+    return createLinkGraphFromELFObject(ObjectBuffer);
   default:
     return make_error<JITLinkError>("Unsupported file format");
   };

diff  --git a/llvm/lib/ExecutionEngine/JITLink/MachO.cpp b/llvm/lib/ExecutionEngine/JITLink/MachO.cpp
index e9327df6da41..eda2b8811deb 100644
--- a/llvm/lib/ExecutionEngine/JITLink/MachO.cpp
+++ b/llvm/lib/ExecutionEngine/JITLink/MachO.cpp
@@ -64,9 +64,9 @@ createLinkGraphFromMachOObject(MemoryBufferRef ObjectBuffer) {
 
     switch (CPUType) {
     case MachO::CPU_TYPE_ARM64:
-      return createLinkGraphFromMachOObject_arm64(std::move(ObjectBuffer));
+      return createLinkGraphFromMachOObject_arm64(ObjectBuffer);
     case MachO::CPU_TYPE_X86_64:
-      return createLinkGraphFromMachOObject_x86_64(std::move(ObjectBuffer));
+      return createLinkGraphFromMachOObject_x86_64(ObjectBuffer);
     }
     return make_error<JITLinkError>("MachO-64 CPU type not valid");
   } else

diff  --git a/llvm/lib/ExecutionEngine/Orc/ObjectLinkingLayer.cpp b/llvm/lib/ExecutionEngine/Orc/ObjectLinkingLayer.cpp
index 5dea8f96314c..6de62f80a96c 100644
--- a/llvm/lib/ExecutionEngine/Orc/ObjectLinkingLayer.cpp
+++ b/llvm/lib/ExecutionEngine/Orc/ObjectLinkingLayer.cpp
@@ -486,7 +486,7 @@ void ObjectLinkingLayer::emit(std::unique_ptr<MaterializationResponsibility> R,
   auto ObjBuffer = O->getMemBufferRef();
   auto Ctx = std::make_unique<ObjectLinkingLayerJITLinkContext>(
       *this, std::move(R), std::move(O));
-  if (auto G = createLinkGraphFromObject(std::move(ObjBuffer)))
+  if (auto G = createLinkGraphFromObject(ObjBuffer))
     link(std::move(*G), std::move(Ctx));
   else
     Ctx->notifyFailed(G.takeError());