[PATCH] D97730: [SDAG] allow vector types for select->logic folds

Tue Mar 2 05:37:13 PST 2021

spatel added a comment.

In D97730#2596428 <https://reviews.llvm.org/D97730#2596428>, @lebedev.ri wrote:

> This looks good to me, thanks.
>
> Should we also deal with the case when the constant contains an `undef`?
> I guess it would be fine to do that in a follow-up.

Yes, I can look at that. It requires some plumbing work: isNullOrNullSplat pipes an optional undef parameter to the underlying isConstOrConstSplat(), but One/AllOnes do not have that option.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97730/new/

https://reviews.llvm.org/D97730