[PATCH] D97763: Add type attributes to LLVM C API

Tue Mar 2 05:25:59 PST 2021

lerno added a comment.

In D97763#2597047 <https://reviews.llvm.org/D97763#2597047>, @arsenm wrote:

> As far as I know we don't have any C API unit tests, but sorely need them if you want to try adding the first

I see echo.cpp utilizing LLVMCreateEnumAttribute (but nothing using LLVMCreateStringAttribute), but I am not familiar with that code.

I submitted this change as there seemed little interest in https://bugs.llvm.org/show_bug.cgi?id=48249 from anyone else and there was a suggestion on the Discord that if I submitted a patch then maybe someone could have a look at it. The code is straightforward, but I don't know LLVM well enough to set up any tests. Both my project (C3) and the Odin Language is looking to use these functions as soon as they are included.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97763/new/

https://reviews.llvm.org/D97763