[PATCH] D97163: [GlobalISel] Implement fewerElements legalization for vector reductions.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:4141
+  default:
+    LLVM_DEBUG(dbgs() << "Unknown reduction kind");
+    return UnableToLegalize;
----------------
Missing newline


================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:4158
+  }
+  MIRBuilder.buildCopy(DstReg, Acc);
+  MI.eraseFromParent();
----------------
Could avoid this copy by using DstReg on the last iteration


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97163/new/

https://reviews.llvm.org/D97163