[PATCH] D97465: [LoopVectorize] Refine hasIrregularType predicate

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:375
 /// type is irregular if its allocated size doesn't equal the store size of an
 /// element of the corresponding vector type at the given vectorization factor.
+static bool hasIrregularType(Type *Ty, const DataLayout &DL) {
----------------
comment needs updating, there's no given vectorization factor any longer, right?


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:377
+static bool hasIrregularType(Type *Ty, const DataLayout &DL) {
   // Determine if an array of VF elements of type Ty is "bitcast compatible"
   // with a <VF x Ty> vector.
----------------
The comment also needs to be updated to not refer to VF I think, as it is gone now. Something like `Determine if an array of type Ty is "bit cast compatible" with a vector with the same number of elements`.


================
Comment at: llvm/test/Transforms/LoopVectorize/irregular_type.ll:5
+; CHECK: vector.body
+; CHECK-NOT: load <4 x i7>
+; CHECK-NOT: store <4 x i7>
----------------
can you add a comment explaining what the test checks?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97465/new/

https://reviews.llvm.org/D97465