[PATCH] D97724: [flang][driver] Add -module-dir alias to f18, also fix -fdefault* family bug

Tue Mar 2 03:49:39 PST 2021

awarzynski added a comment.

This patch will allow us to share the tests for `-fdefault-{double-8|integer-8|real-8}` and `-flarge-sizes` (introduced in https://reviews.llvm.org/D96344) between `f18` and `flang-new`. This is a very much welcomed change, thank you!

I don't think that we need any changes for `-module` though. `f18` already supports `-module-dir` and there are no tests using `-module` that would require this change in the future. Please, could you revert it?

Ideally this patch would be accompanied with tests, but since D96344 <https://reviews.llvm.org/D96344> is practically ready to land (and which contains tests for this), I suggest that we merge this as is. Could you mention e.g. in the commit message that tests will be added in a forthcoming patch? Thank you!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97724/new/

https://reviews.llvm.org/D97724