[PATCH] D97587: [AMDGPU] Make OMod explicit for V_CVT_{U,I}*

[Jay Foad via Phabricator via llvm-commits]

foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.

LGTM since these instructions are documented as supporting OMOD.



================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.td:1626
         // VOP1 with modifiers
-        (ins Src0Mod:$src0_modifiers, Src0RC:$src0,
-             clampmod0:$clamp, omod0:$omod)
+        !if(HasOMod,
+          (ins Src0Mod:$src0_modifiers, Src0RC:$src0,
----------------
Not really related to your patch, but couldn't we clean up all these nested `!if`s by using a big `!con` of little fragments like `!if(HasOMod, (ins omod0:$omod), (ins))`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97587/new/

https://reviews.llvm.org/D97587