[PATCH] D97761: [WebAssembly] Swap operand order of call_indirect in text format

Andy Wingo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 2 03:25:53 PST 2021


wingo created this revision.
wingo added a reviewer: tlively.
Herald added subscribers: ecnelises, arphaman, sunfish, hiraditya, jgravelle-google, dschuff.
wingo requested review of this revision.
Herald added subscribers: llvm-commits, aheejin.
Herald added a project: LLVM.

The WebAssembly text and binary formats have different operand orders
for the "type" and "table" fields of call_indirect (and
return_call_indirect).  In LLVM we use the binary order for the MCInstr,
but when we produce or consume the text format we should use the text
order.  For compilation units targetting WebAssembly 1.0 (without the
reference types feature), we omit the table operand entirely.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D97761

Files:
  llvm/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp
  llvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyInstPrinter.cpp
  llvm/lib/Target/WebAssembly/WebAssemblyFastISel.cpp
  llvm/test/CodeGen/WebAssembly/function-pointer64.ll
  llvm/test/CodeGen/WebAssembly/multivalue.ll
  llvm/test/MC/WebAssembly/basic-assembly.s
  llvm/test/MC/WebAssembly/call-indirect-relocs.s
  llvm/test/MC/WebAssembly/tail-call-encodings.s
  llvm/test/MC/WebAssembly/type-index.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D97761.327403.patch
Type: text/x-patch
Size: 12239 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210302/3faa75a7/attachment.bin>


More information about the llvm-commits mailing list