[PATCH] D97670: [AMDGPU] New intrinsic void llvm.amdgcn.s.sethalt(i32)

[Jay Foad via Phabricator via llvm-commits]

foad added a comment.

In D97670#2596219 <https://reviews.llvm.org/D97670#2596219>, @t-tye wrote:

> A better alternative is to use the llvm.debug intrinsic

It looks like llvm.debugtrap is only supported on HSA?

> that will notify the debugger when executed, and also halt the wave for the debugger to resume.

Right, I realise that llvm.debugtrap/s_trap is a more normal way of breaking into a debugger. But there is more than one debugger, and more than one way of debugging things, and for cases where you want to halt the program and attach a debugger after the fact, llvm.amdgcn.s.sethalt/s_sethalt seems like a useful thing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97670/new/

https://reviews.llvm.org/D97670