[PATCH] D97686: [test-suite] Fix Unit Tests for Code Coverage

[Sam Elliott via Phabricator via llvm-commits]

lenary added a comment.

In D97686#2596453 <https://reviews.llvm.org/D97686#2596453>, @yroux wrote:

> Hi Sam,
>
> the overall patch looks good to me, I just spot that these macros are explicitly defined into SingleSource/Regression/C/casts.c if PRId64 doesn't exist.
> So I wonder if this guarf is needed on some plateform

I don't think we should be providing definitions if they aren't provided already, as we don't know if the platform is ILP32/LP64/LLP64 -- which was the original point in this patch.

As it is right now, this will fail at compile-time if you don't have these macros, which I think is ok. It should be up to the platforms without these `inttypes.h` definitions to exclude these tests with a downstream cmake patch if they don't support these macros (or indeed the types that go with them).


Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97686/new/

https://reviews.llvm.org/D97686