[PATCH] D96628: [VPlan] Add plain text (not DOT's digraph) dumps

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 2 01:47:27 PST 2021


fhahn added a comment.

Thanks for working on this! Could you split off the changes not directly related to printing in non-DOT mode (like respecting Indent in the individual print() implementations)? Then we can focus the review here on the details how to move to support non-DOT printing, which is very valuable IMO and should probably become the default in the long run.



================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.cpp:907
                               VPSlotTracker &SlotTracker) const {
-  O << "WIDEN-CALL ";
+  O << Indent << "WIDEN-CALL ";
 
----------------
Could you split off the changes not directly related to printing in non-DOT mode (like respecting `Indent` in the individual print() implementations)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96628/new/

https://reviews.llvm.org/D96628



More information about the llvm-commits mailing list