[PATCH] D97749: [flang] Detect circularly defined interfaces of procedures

[Peter Klausler via Phabricator via llvm-commits]

klausler accepted this revision.
klausler added inline comments.
This revision is now accepted and ready to land.


================
Comment at: flang/include/flang/Semantics/symbol.h:775
+};
+using SymbolSet = std::unordered_set<SymbolRef, SymbolHash>;
 
----------------
We should think about renaming this typedef.  It's not really a set of arbitrary Symbol references any more, since two Symbols with the same name strings will clash.  SymbolSet seems to me like a name for what would be an unordered_set that hashed the addresses of the Symbols instead.

We don't have to fix this in this patch; I'll try to clean things up more afterwards.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97749/new/

https://reviews.llvm.org/D97749