[PATCH] D97694: [lli] Test debug support in RuntimeDyld with built-in functions

[Lang Hames via Phabricator via llvm-commits]

lhames accepted this revision.
lhames added a comment.
This revision is now accepted and ready to land.

> I can imagine tests like these will be handy for testing advanced JIT features inside LLVM in the future. Adding the -generate flag with a hard-coded set of options was not my preferred solution, but all other attempts failed for portability reasons. I am happy to discuss ideas how to improve it.

What other options did you consider?
How about a list of strings, rather than hard-coded options?
Or writing `__dump_jit_debug_descriptor` and `__dump_jit_debug_objects` as extern "C" functions and dispensing with the generator entirely (they'd be picked up as process symbols)?

I think you can land this as-is and we can revise the design later if we come up with a better approach.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97694/new/

https://reviews.llvm.org/D97694