[PATCH] D97610: [lld-macho] check minimum header length when opening linkable input files

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 1 16:07:27 PST 2021


thakis added a comment.

a) I think this breaks --reproduce=repro.tar for `-order_file` since that previously called `readFile()` which added to the repro tar, but now `readRawFile()` doesn't. (Looks like -sectcreate has the same problem likely.)
b) What's the motivation for this change? lld assumes that inputs are produced by a compiler or similar, and are generally valid. What problem is this solving?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97610/new/

https://reviews.llvm.org/D97610



More information about the llvm-commits mailing list