[PATCH] D97656: [llvm-objcopy] Initial XCOFF32 support.
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 1 14:34:52 PST 2021
MaskRay added inline comments.
================
Comment at: llvm/test/tools/llvm-objcopy/XCOFF/basic-copy.test:25
+ StorageClass: C_FILE
+ NumberOfAuxEntries: 1
+ - Name: .text
----------------
Shouldn't the aux record follow the entry?
================
Comment at: llvm/test/tools/llvm-objcopy/XCOFF/basic-copy.test:37
+ StorageClass: C_EXT
+ NumberOfAuxEntries: 1
----------------
See ELF tests. We usually align the values (`1` and `C_EXT` above, and all other values above).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97656/new/
https://reviews.llvm.org/D97656
More information about the llvm-commits
mailing list