[llvm] 3e8223b - [AArch64][GlobalISel] NFC: Remove dead G_BUILD_VECTOR legalization rule

Jessica Paquette via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 1 14:05:21 PST 2021


Author: Jessica Paquette
Date: 2021-03-01T14:04:40-08:00
New Revision: 3e8223b16515443a254ff6ad3453a82602b4b9a0

URL: https://github.com/llvm/llvm-project/commit/3e8223b16515443a254ff6ad3453a82602b4b9a0
DIFF: https://github.com/llvm/llvm-project/commit/3e8223b16515443a254ff6ad3453a82602b4b9a0.diff

LOG: [AArch64][GlobalISel] NFC: Remove dead G_BUILD_VECTOR legalization rule

Remove a rule which allows larger scalar types than the destination vector
element type.

This appears to be irrelevant now that we have G_BUILD_VECTOR_TRUNC. Plus,
making a G_BUILD_VECTOR which satisfies this introduces a verifier failure
anyway.

Differential Revision: https://reviews.llvm.org/D97727

Added: 
    

Modified: 
    llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.cpp b/llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.cpp
index f93b099c86e8..9ed4e6a43f84 100644
--- a/llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.cpp
+++ b/llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.cpp
@@ -636,12 +636,6 @@ AArch64LegalizerInfo::AArch64LegalizerInfo(const AArch64Subtarget &ST)
                  {v2s64, s64}})
       .clampNumElements(0, v4s32, v4s32)
       .clampNumElements(0, v2s64, v2s64)
-
-      // Deal with larger scalar types, which will be implicitly truncated.
-      .legalIf([=](const LegalityQuery &Query) {
-        return Query.Types[0].getScalarSizeInBits() <
-               Query.Types[1].getSizeInBits();
-      })
       .minScalarSameAs(1, 0);
 
   getActionDefinitionsBuilder(G_CTLZ)


        


More information about the llvm-commits mailing list