[PATCH] D97727: [AArch64][GlobalISel] NFC: Remove dead G_BUILD_VECTOR legalization rule

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 1 13:34:53 PST 2021


paquette created this revision.
paquette added a reviewer: aemerson.
Herald added subscribers: danielkiss, hiraditya, kristof.beyls, rovka.
paquette requested review of this revision.
Herald added a project: LLVM.

Remove a rule which allows larger scalar types than the destination vector element type.

This appears to be irrelevant now that we have G_BUILD_VECTOR_TRUNC. Plus, making a G_BUILD_VECTOR which satisfies this introduces a verifier failure anyway.


https://reviews.llvm.org/D97727

Files:
  llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.cpp


Index: llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.cpp
===================================================================
--- llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.cpp
+++ llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.cpp
@@ -636,12 +636,6 @@
                  {v2s64, s64}})
       .clampNumElements(0, v4s32, v4s32)
       .clampNumElements(0, v2s64, v2s64)
-
-      // Deal with larger scalar types, which will be implicitly truncated.
-      .legalIf([=](const LegalityQuery &Query) {
-        return Query.Types[0].getScalarSizeInBits() <
-               Query.Types[1].getSizeInBits();
-      })
       .minScalarSameAs(1, 0);
 
   getActionDefinitionsBuilder(G_CTLZ)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D97727.327269.patch
Type: text/x-patch
Size: 700 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210301/4132a2f6/attachment.bin>


More information about the llvm-commits mailing list