[PATCH] D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format
Yusra Syeda via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 1 13:25:11 PST 2021
yusra.syeda added a comment.
In D89071#2486161 <https://reviews.llvm.org/D89071#2486161>, @jhenderson wrote:
> I've not reviewed the testing yet, but my immediate thought is that there needs to be a lot more, handling all the different code paths.
@jhenderson can you please review the testing? Currently the tests construct a GOFF object with a valid sized record (80 bytes), an invalid sized record (!80 bytes), and obtains the symbol name from the ESD record. Testing for relocations will be added in a future patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89071/new/
https://reviews.llvm.org/D89071
More information about the llvm-commits
mailing list