[PATCH] D97564: [WebAssembly] Fix split-dwarf not emitting DW_OP_WASM_location correctly

[Wouter van Oortmerssen via Phabricator via llvm-commits]

aardappel added inline comments.


================
Comment at: llvm/test/MC/WebAssembly/dwarfdump.ll:68
+; SPLIT-NEXT:               DW_AT_name        ("test.c")
+; SPLIT-NEXT:               DW_AT_GNU_dwo_name        ("C:\\src\\llvm\\llvm\\test\\MC\\WebAssembly\\dwarfdump.ll.dwo")
+; SPLIT-NEXT:               DW_AT_GNU_dwo_id  (0xad3151f12153fa17)
----------------
dschuff wrote:
> wait, did my comment get eaten by Phabricator?
> 
> This path check will presumably fail on non-windows. I guess it's because %s gets expanded to an absolute path by lit. I guess we could just check for a regex that only matches DW_AT_GNU_dwo_name, and the filename?
Thanks, nice catch.. would have definitely broken the build.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97564/new/

https://reviews.llvm.org/D97564