[PATCH] D97664: [llvm-objcopy][test] Fix test that could have passed spuriously
    Fangrui Song via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Mon Mar  1 11:27:09 PST 2021
    
    
  
MaskRay added inline comments.
================
Comment at: llvm/test/tools/llvm-objcopy/ELF/strip-unneeded-all-symbols.test:14
   Data:     ELFDATA2LSB
   Type:     ET_EXEC
   Machine:  EM_X86_64
----------------
If I change `ET_EXEC` to `ET_REL`, the test fails as intended.
Adding more tests is fine. Perhaps we need two tests (use something like `Type: [[type]]`).
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97664/new/
https://reviews.llvm.org/D97664
    
    
More information about the llvm-commits
mailing list