[PATCH] D97649: [InstrProfiling] Place __llvm_prf_vnodes and __llvm_prf_names in llvm.used on ELF

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 1 10:50:02 PST 2021


davidxl added inline comments.


================
Comment at: compiler-rt/test/profile/Linux/instrprof-value-merge.c:1
+// REQUIRES: linux, lld-available
 // RUN: %clang_pgogen -o %t -O3 %s
----------------
Is it better to split the test into multiple RUN file based tests with only one requires linux and lld? Otherwise it seems that adding this will disable the tests on some bots (freebsd or no lld).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97649/new/

https://reviews.llvm.org/D97649



More information about the llvm-commits mailing list