[PATCH] D97641: [lld/mac] Add support for -flat_namespace

[Jez Ng via Phabricator via llvm-commits]

int3 added inline comments.


================
Comment at: lld/test/MachO/flat-namespace.s:38-39
+
+# No "(dynamically looked up)" because llvm-nm -m doesn't print that
+# for files without MH_TWOLEVEL for some reason.
+# FLATSYM: (undefined) external _bar
----------------
thakis wrote:
> int3 wrote:
> > does `llvm-objdump --syms` or `llvm-readobj` print anything better?
> `llvm-objdump --syms` doesn't print it. `llvm-readobj` has it as `Flags [ (0xFE00)`. obj2yaml also prints it as `n_desc:          65024`.
> 
> I think we definitely want to test `nm` here since that's what end users are most likely to use. Want me to add a readobj/yaml2obj test in addition to what's here, or nah?
A readobj test would be nice :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97641/new/

https://reviews.llvm.org/D97641