[PATCH] D96351: [AIX] Enable the default AltiVec ABI on AIX

[Sean Fertile via Phabricator via llvm-commits]

sfertile added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-csr-vector.ll:3
+; RUN:     -mattr=+altivec -stop-after=prologepilog < %s | \
+; RUN:   FileCheck --check-prefixes=MIR32 %s
+
----------------
Minor nit: when there is a single check prefix use `--check-prefix=`


================
Comment at: llvm/test/CodeGen/PowerPC/aix-csr-vector.ll:26
+; MIR32:         fixedStack:      []
+; MIR32:         INLINEASM
+; MIR32:         BLR implicit $lr, implicit $rm
----------------
Ideally we would either have check-nots for v20/v26/v31 before and after the INLINEASM instruction(or APP/NO_APP). Or maybe if you check for the basic-block label then check-next the following instructions to the blr might be an equivalent way to show the same understanding.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-inlineasm-reserved-reg-dflt-warn.ll:3
+; RUN:     -mcpu=pwr7 -mattr=+altivec 2>&1 | \
+; RUN:   FileCheck --check-prefixes=DFLTWRN %s
+
----------------
Minor nit: Just use 'CHECK:' so we can drop the `--check-prefixes`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96351/new/

https://reviews.llvm.org/D96351