[PATCH] D87202: Add new choices dot-cfg and dot-cfg-quiet to print-changed which creates a website of DOT files showing colourized changes as the IR is changed by passes in the new pass manager pipeline.

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 1 10:25:55 PST 2021


aeubanks added inline comments.


================
Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:34
 #include "llvm/Support/raw_ostream.h"
+#include <regex>
+#include <unordered_map>
----------------
looks like llvm doesn't really use <regex> a lot, and I vaguely remember hearing bad things about it.
Does llvm/include/llvm/Support/Regex.h work?


================
Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:1364
+
+  // There appears to be an optimization bug in the build compiler in
+  // that when begin() and end() are called from GraphWriter, the pointer to
----------------
we should really get this figured out


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87202/new/

https://reviews.llvm.org/D87202



More information about the llvm-commits mailing list