[PATCH] D97360: [TTI] Consider select form of and/or i1 as having arithmetic cost

Juneyoung Lee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 1 09:04:22 PST 2021


aqjune added a comment.

In D97360#2594461 <https://reviews.llvm.org/D97360#2594461>, @spatel wrote:

> In D97360#2594420 <https://reviews.llvm.org/D97360#2594420>, @aqjune wrote:
>
>> Would adding 'select -> and/or i1' transformation into the end of CodeGenPrepare::runOnFunction work?
>> I see that there are quite many targets that generate different assemblies for select vs. and/or i1.
>
> No, I think we should adjust some code in DAGCombiner for this. I was already looking at it, so I can continue if you want to keep working on the IR side.
>
> LGTM.

This is great, thank you!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97360/new/

https://reviews.llvm.org/D97360



More information about the llvm-commits mailing list