[PATCH] D97689: [AMDGPU][MC][GFX9+] Corrected encoding of op_sel_hi for unused operands in VOP3P

Mon Mar 1 08:54:55 PST 2021

Joe_Nash added a comment.

In D97689#2594419 <https://reviews.llvm.org/D97689#2594419>, @Joe_Nash wrote:

> In D97689#2594395 <https://reviews.llvm.org/D97689#2594395>, @dp wrote:
>
>> I was surprised to discover that codegen tests include encodings. Is there any reason for that? Should I remove or update them?
>
> Yes, it is surprising. I am inclined to say remove the encodings.

Looking at the blame now, arsenm added the encoding checks that are failing in 2020, so perhaps those should be converted into assembler tests.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97689/new/

https://reviews.llvm.org/D97689