[PATCH] D97689: [AMDGPU][MC][GFX9+] Corrected encoding of op_sel_hi for unused operands in VOP3P

[Dmitry Preobrazhensky via Phabricator via llvm-commits]

dp created this revision.
dp added a reviewer: rampitec.
Herald added subscribers: kerbowa, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl, arsenm.
dp requested review of this revision.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.

Summary of changes:

- VOP3P op_sel_hi is encoded as 1 for unused operands;
- Disassembler can correctly decode VOP3P instructions regardless of op_sel_hi value for unused operands.

Fixed bug 49363 <https://bugs.llvm.org/show_bug.cgi?id=49363>.


https://reviews.llvm.org/D97689

Files:
  llvm/lib/Target/AMDGPU/MCTargetDesc/SIMCCodeEmitter.cpp
  llvm/lib/Target/AMDGPU/SIDefines.h
  llvm/lib/Target/AMDGPU/VOPInstructions.td
  llvm/test/MC/AMDGPU/expressions-gfx9.s
  llvm/test/MC/AMDGPU/gfx90a_asm_features.s
  llvm/test/MC/AMDGPU/gfx9_asm_vop3p.s
  llvm/test/MC/AMDGPU/lds_direct.s
  llvm/test/MC/AMDGPU/literals.s
  llvm/test/MC/AMDGPU/literalv216.s
  llvm/test/MC/AMDGPU/vop3-literal.s
  llvm/test/MC/AMDGPU/vop3p.s
  llvm/test/MC/Disassembler/AMDGPU/gfx90a_dasm_features.txt
  llvm/test/MC/Disassembler/AMDGPU/gfx9_dasm_all.txt
  llvm/test/MC/Disassembler/AMDGPU/lds_direct_gfx9.txt
  llvm/test/MC/Disassembler/AMDGPU/literal_gfx9.txt
  llvm/test/MC/Disassembler/AMDGPU/literalv216_gfx10.txt
  llvm/test/MC/Disassembler/AMDGPU/vop3-literal.txt
  llvm/test/MC/Disassembler/AMDGPU/vop3p_opsel.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D97689.327103.patch
Type: text/x-patch
Size: 352383 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210301/5bc0883d/attachment-0001.bin>