[PATCH] D97670: [AMDGPU] New intrinsic void llvm.amdgcn.s.sethalt(i32)

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/include/llvm/IR/IntrinsicsAMDGPU.td:1288
+  Intrinsic<[], [llvm_i32_ty], [ImmArg<ArgIndex<0>>, IntrNoMem,
+                                IntrHasSideEffects, IntrWillReturn]>;
+
----------------
arsenm wrote:
> Is this really willreturn?
Yes, as far as the generated code is concerned. It doesn't really know that it'll be stopped in the debugger for a while, and we definitely want it to function correctly if/when the debugger resumes it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97670/new/

https://reviews.llvm.org/D97670