[PATCH] D97635: GlobalISel: Move splitToValueTypes to generic code

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 1 05:45:22 PST 2021


arsenm added a comment.

In D97635#2593895 <https://reviews.llvm.org/D97635#2593895>, @kschwarz wrote:

> Is there a plan to eventually get rid of the EVTs in call lowering and directly work with the LLVM IR Type?

The EVT usage is just to bootstrap on top of the DAG infrastructure. Ideally we will eventually get rid of it and only use LLT

> Our downstream target needs special handling for pointer arguments, but unfortunately ComputeValueVTs loses the information about pointerness.
> We solved this by directly operating on the LLVM IR type, although we do not handle vectors yet, which makes this a bit simpler

ComputeValueVTs loses it, but the hack the DAG uses still should work. ArgFlagsTy still should contain the discarded address spaces


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97635/new/

https://reviews.llvm.org/D97635



More information about the llvm-commits mailing list