[PATCH] D97470: [CostModel] Align the cost model for intrinsics for scalable/fixed-width vectors.

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 1 05:33:23 PST 2021


sdesmalen added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/BasicTTIImpl.h:1345
     // intrinsic.
     unsigned ScalarizationCost = std::numeric_limits<unsigned>::max();
+    if (RetVF.isVector() && !RetVF.isScalable()) {
----------------
dmgreen wrote:
> Should this ScalarizationCost and IntrinsicCostAttributes::ScalarizationCost be converted to InstructionCost too?
Yes, I have another patch for that which updates the interface of getScalarizationOverhead to return InstructionCost at which points this needs to become an InstructionCost as well. I haven't posted this patch yet, but will do so soon.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97470/new/

https://reviews.llvm.org/D97470



More information about the llvm-commits mailing list