[PATCH] D97598: [NFC][AMDGPU] Document the AMDGPU target feature defaults

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 1 00:59:10 PST 2021


foad added inline comments.


================
Comment at: llvm/docs/AMDGPUUsage.rst:509-528
+                                                  If not specified for code object V2 to V3, generate
+                                                  code that can be loaded and executed in a process
+                                                  with XNACK replay enabled.
+
+                                                  If not specified for code object V4, generate
+                                                  code that can be loaded and executed in a process
+                                                  with either setting of XNACK replay.
----------------
Isn't your third paragraph here just explaining that the first two are identical? I.e. "generate code that works with xnack replay enabled" and "generate code that works whether xnack replay is enabled or not" are the same thing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97598/new/

https://reviews.llvm.org/D97598



More information about the llvm-commits mailing list