[PATCH] D97633: [cmake] Link socket/nsl on SunOS in llvm-jitlink

serge via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 1 00:25:08 PST 2021


serge-sans-paille added inline comments.


================
Comment at: llvm/tools/llvm-jitlink/CMakeLists.txt:28
+if(${CMAKE_SYSTEM_NAME} MATCHES "SunOS")
+  target_link_libraries(llvm-jitlink PRIVATE socket nsl)
+endif()
----------------
Are `socket` and  `nsl` libraries standard and always available, or should we check for them?


================
Comment at: llvm/tools/llvm-jitlink/llvm-jitlink-executor/CMakeLists.txt:14
 
+message(${CMAKE_SYSTEM_NAME})
+if(${CMAKE_SYSTEM_NAME} MATCHES "SunOS")
----------------
debug leftover?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97633/new/

https://reviews.llvm.org/D97633



More information about the llvm-commits mailing list