[PATCH] D91920: [Flang] [OpenMP] Add semantic checks for OpenMP firstprivate , lastprivate and copyprivate clauses

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan added a comment.

In D91920#2593420 <https://reviews.llvm.org/D91920#2593420>, @praveen wrote:

> @kiranchandramohan The test case flang/test/Semantics/resolve102.f90 is failing with the error messages possibly due to the commit
>
> https://github.com/llvm/llvm-project/commit/07de0846a5055015b55dc2b8faa2143f9902e549#diff-bc82e30d81709b26f2c8030300784e95003f1b968e1ed7842fa717858e497336
>
> actual at 13: Procedure 'p' is recursively defined.  Procedures in the cycle: 'p2', 'sub', 'p'
> expect at 13: Procedure 'p' is recursively defined.  Procedures in the cycle: 'p2', 'p', 'sub'
> actual at 25: Procedure 'p' is recursively defined.  Procedures in the cycle: 'p2', 'sub', 'p'
> expect at 25: Procedure 'p' is recursively defined.  Procedures in the cycle: 'p2', 'p', 'sub'
>
> Can I push this patch now or only after the above failed case is fixed ?

You can push it now since the failure is unrelated to your patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91920/new/

https://reviews.llvm.org/D91920