[PATCH] D97342: [AMDGPU] Skip unclusterd rescheduling w/o ld/st

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 26 11:55:13 PST 2021


rampitec added a comment.

In D97342#2590876 <https://reviews.llvm.org/D97342#2590876>, @rampitec wrote:

> In D97342#2590737 <https://reviews.llvm.org/D97342#2590737>, @rampitec wrote:
>
>> In D97342#2590002 <https://reviews.llvm.org/D97342#2590002>, @vpykhtin wrote:
>>
>>> Looks good, but should we use just a single dedicated pass over SUs to check if there're clustered ops after first scheduling to make the logic slightly easier?
>>
>> My problem with that it has to be done in the schedule() method or somewhere else within GCNScheduleDAGMILive. The only way to get an SUnit there is to call getSUnit() passing a MachineInstr and that is a map lookup. I.e. it is simply slower and I am trying to squeeze as much speed as I could.
>
> Actually it is not even possible. The place where I can do it does not have mutations applied yet.

In fact I did the experiment, it may look better but I've got 3.6% slower scheduling with that separate loop.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97342/new/

https://reviews.llvm.org/D97342



More information about the llvm-commits mailing list