[PATCH] D94741: [Utils][WIP] Check for more global information in update_test_checks

Kuter Dinel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 28 18:33:59 PST 2021


kuter added a comment.

dict.keys() gives a dict_keys object which isn't a list. [:] doesn't work on it.



================
Comment at: llvm/utils/UpdateTestChecks/common.py:602
+
+      global_vars_seen_before = global_vars_seen.keys()[:]
 
----------------



================
Comment at: llvm/utils/UpdateTestChecks/common.py:740
+
+        global_vars_seen_before = global_vars_seen.keys()[:]
+        for line in glob_val_dict[checkprefix][nameless_value.check_prefix]:
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94741/new/

https://reviews.llvm.org/D94741



More information about the llvm-commits mailing list