[PATCH] D97403: updated character tests to gtest

[Asher Mancinelli via Phabricator via llvm-commits]

ashermancinelli added inline comments.


================
Comment at: flang/unittests/RuntimeGTest/CharacterTest.cpp:96-97
+struct CharacterComparisonTests : public ::testing::Test {
+  CharacterComparisonTests()
+      : parameters(CreateParameters<CHAR>()),
+        characterComparisonFunc(CreatecharacterComparisonFunc<CHAR>()) {}
----------------
An alternative solution to the `CreateParameters` function would be a static tuple of type `tuple<vector<PARAMETER<char>>, vector<PARAMETER<char16_t>>, ...>`. This way, initializing `parameters` would just be `std::get<CHAR>(AnswerKey)` or something similar. If anyone thinks this or another solution would be better than what I've used here, please let me know.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97403/new/

https://reviews.llvm.org/D97403