[PATCH] D96613: [lld] Add options to trace all symbols and to trace all symbols originated from a file

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 27 23:21:30 PST 2021


MaskRay added a comment.

I have several concerns.

- The slowdown. You can test some internal projects.
- This does not work with versioned symbols in shared objects.
- `The patch uses this->file, however, the value may change if the symbol gets resolved to other files. In the cases I can conceive we want the trace of the full lifetime of a symbol, not only when it is bound to a specific file.`
- The usefulness is not justified. This looks like a debug option. I raised `ld.lld @response.txt $(llvm-nm -Du usr/lib64/libc.so.6 | awk '{print "-y"substr($0,20)}')` as an example how this can be trivially implemented with tool composing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96613/new/

https://reviews.llvm.org/D96613



More information about the llvm-commits mailing list