[PATCH] D96883: Add support for JSON output style to llvm-symbolizer
Alex Orlov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Feb 27 12:08:49 PST 2021
aorlov added inline comments.
================
Comment at: llvm/test/tools/llvm-symbolizer/output-style-json.test:7
+
+# NO-INLINES:some text
+# NO-INLINES-NEXT:{
----------------
jhenderson wrote:
> This line isn't valid JSON. I think we should either omit it entirely or encode it in a JSON object somehow, so that we consumers can still read the output.
Right. I have added the error handling and the error code/message printout in JSON.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96883/new/
https://reviews.llvm.org/D96883
More information about the llvm-commits
mailing list