[PATCH] D97610: [lld-macho] check minimum header length when opening linkable input files

Greg McGary via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 27 11:41:24 PST 2021


gkm marked 4 inline comments as done.
gkm added inline comments.


================
Comment at: lld/test/MachO/rename.s:17
+# BAD1: lld: error: invalid name for segment or section: -o
+# BAD1: lld: error: file is too small to contain a linkable-file header: /dev/null
+
----------------
int3 wrote:
> we shouldn't be emitting this message if `/dev/null` is an output file parameter
The `-o` was swallowed by `-rename_section` because of a missing sub arg. Therefore, it is interpreted as an input parameter.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97610/new/

https://reviews.llvm.org/D97610



More information about the llvm-commits mailing list