[llvm] c81dde9 - [llvm-readobj] Use ListSeparator (NFC)
Kazu Hirata via llvm-commits
llvm-commits at lists.llvm.org
Sat Feb 27 10:09:49 PST 2021
Author: Kazu Hirata
Date: 2021-02-27T10:09:22-08:00
New Revision: c81dde9292817e02e55d0096a7ecc322f1a0984b
URL: https://github.com/llvm/llvm-project/commit/c81dde9292817e02e55d0096a7ecc322f1a0984b
DIFF: https://github.com/llvm/llvm-project/commit/c81dde9292817e02e55d0096a7ecc322f1a0984b.diff
LOG: [llvm-readobj] Use ListSeparator (NFC)
Added:
Modified:
llvm/tools/llvm-readobj/ELFDumper.cpp
Removed:
################################################################################
diff --git a/llvm/tools/llvm-readobj/ELFDumper.cpp b/llvm/tools/llvm-readobj/ELFDumper.cpp
index e353b17f7a44..03288e4a45c9 100644
--- a/llvm/tools/llvm-readobj/ELFDumper.cpp
+++ b/llvm/tools/llvm-readobj/ELFDumper.cpp
@@ -3935,21 +3935,17 @@ template <class ELFT> void GNUELFDumper<ELFT>::printSectionDetails() {
uint64_t Flags = S.sh_flags;
uint64_t UnknownFlags = 0;
- bool NeedsComma = false;
+ ListSeparator LS;
while (Flags) {
// Take the least significant bit as a flag.
uint64_t Flag = Flags & -Flags;
Flags -= Flag;
auto It = FlagToName.find(Flag);
- if (It != FlagToName.end()) {
- if (NeedsComma)
- OS << ", ";
- NeedsComma = true;
- OS << It->second;
- } else {
+ if (It != FlagToName.end())
+ OS << LS << It->second;
+ else
UnknownFlags |= Flag;
- }
}
auto PrintUnknownFlags = [&](uint64_t Mask, StringRef Name) {
@@ -3957,12 +3953,9 @@ template <class ELFT> void GNUELFDumper<ELFT>::printSectionDetails() {
if (!FlagsToPrint)
return;
- if (NeedsComma)
- OS << ", ";
- OS << Name << " ("
+ OS << LS << Name << " ("
<< to_string(format_hex_no_prefix(FlagsToPrint, AddrSize)) << ")";
UnknownFlags &= ~Mask;
- NeedsComma = true;
};
PrintUnknownFlags(SHF_MASKOS, "OS");
More information about the llvm-commits
mailing list