[PATCH] D97500: [flang][fir] Add remaining Ops. Updates to pre-existing Ops.

[Eric Schweitz via Phabricator via llvm-commits]

schweitz added inline comments.


================
Comment at: flang/include/flang/Optimizer/Dialect/FIROps.td:1015-1018
+    Optional<AnyShapeType>:$shape,
+    Optional<fir_SliceType>:$slice,
+    Variadic<AnyIntegerType>:$lenParams,
+    OptionalAttr<AffineMapAttr>:$accessMap
----------------
kiranchandramohan wrote:
> Nit: Might be good to have some documentation for the new arguments.
+1


================
Comment at: flang/include/flang/Optimizer/Dialect/FIROps.td:2286
     Generalized high-level looping construct. This operation is similar to
     MLIR's `loop.for`.
 
----------------
kiranchandramohan wrote:
> Nit: (unrelated) scf.for now. Needs a description update.
+1


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97500/new/

https://reviews.llvm.org/D97500