[PATCH] D97585: [InstrProfiling] Use llvm.compiler.used instead of llvm.used for ELF

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D97585#2591594 <https://reviews.llvm.org/D97585#2591594>, @davidxl wrote:

> lgtm for ELF.   Anything to do for COFF?

I think the existing behavior may be a bit problematic for COFF, so let @rnk know and add some tests demonstrating the behavior:)

Perhaps COFF should switch to comdat and `llvm.compiler.used` as well. Without comdat, because currently `llvm.used` does not retain section defining PrivateLinkage/InternalLinkage symbols, the GC result may be weird.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97585/new/

https://reviews.llvm.org/D97585