[PATCH] D97559: [RISCV] Support INSERT_SUBVECTOR on vector masks

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 26 16:09:35 PST 2021


craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:2583
+  // required.
+  if (VecVT != Op.getSimpleValueType())
+    Slideup = DAG.getBitcast(Op.getSimpleValueType(), Slideup);
----------------
You can call getBitcast unconditionally.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97559/new/

https://reviews.llvm.org/D97559



More information about the llvm-commits mailing list