[PATCH] D97521: [lld/mac] Add some support for dynamic lookup symbols, and implement -U

[Nico Weber via Phabricator via llvm-commits]

thakis marked 3 inline comments as done.
thakis added a comment.

Ok, this is ready now :)



================
Comment at: lld/MachO/SyntheticSections.cpp:268-278
+
+  // XXX named constant for -2
+  int32_t ordinal = dysym->isDynamicLookup() ? -2 : dysym->getFile()->ordinal;
+
+  if (lastBinding.ordinal != ordinal) {
+    if (ordinal < 0) {
+      assert(ordinal == -2);
----------------
int3 wrote:
> you should pull and rebase past {D95913}
Hey, nice :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97521/new/

https://reviews.llvm.org/D97521