[PATCH] D96647: [BasicAA] Add depth limit

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 26 13:17:51 PST 2021


nikic added a comment.

While changing this to limit number of recursive queries instead of depth, I ran into some issues trying to keep BatchAA consistency. My assumption was that if a recursive query hits the limit and returns MayAlias, the whole query will be MayAlias. However, while this is true for BasicAA in isolation, it isn't true when combined with e.g. GlobalsAA. This means we can't accurately emulate the result of a query as if it weren't cached, or at least I don't see any obvious way. Possibly we need to relax this to "BatchAA should not produce worse results than AA" rather than "BatchAA should produce the same results as AA".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96647/new/

https://reviews.llvm.org/D96647



More information about the llvm-commits mailing list