[PATCH] D97568: [ARM] support symbolic expressions as branch target in b.w

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers added inline comments.


================
Comment at: llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp:7955
+    // Delay the checks of symbolic expressions until they are resolved
+    if (dyn_cast<MCConstantExpr>(Operand.getImm()) &&
+        !Operand.isSignedOffset<24, 1>())
----------------
if you don't use the return value from `dyn_cast`, you should use `isa`.
https://llvm.org/docs/ProgrammersManual.html#the-isa-cast-and-dyn-cast-templates

or rewrite this as two nested `if`s:

```
if (auto foo = dyn_cast<...):
  if (!foo.isSignedOffset<...):
    return Error(...);
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97568/new/

https://reviews.llvm.org/D97568