[PATCH] D97564: [WebAssembly] Fix split-dwarf not emitting DW_OP_WASM_location correctly

Derek Schuff via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 26 11:33:39 PST 2021


dschuff added a comment.

Would it make sense to also run e.g. llvm/test/MC/WebAssembly/debug-localvar.ll with split-dwarf?



================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp:475
+          // symbols are (with entries in .debug_addr).
+          // For now, since we only ever use index 0, this should work as-is.        
+          addUInt(*Loc, dwarf::DW_FORM_data4,
----------------
Can we assert that the index is 0?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97564/new/

https://reviews.llvm.org/D97564



More information about the llvm-commits mailing list