[PATCH] D97514: [SystemZ] Assign the full space for promoted and split outgoing args

[Jonas Paulsson via Phabricator via llvm-commits]

jonpa updated this revision to Diff 326725.
jonpa added a comment.

Updated per review.

> I'm wondering whether it wouldn't be better to follow that model here. (E.g. by using CreateStackTemporary with a size instead of a type, and computing the size as "number-of-parts * size-of-part".)

I think you are right - reading the comment yesterday for getTypeToTransformTo() seemed to make sense to me for the promoted integer types, but I see now that the second (new) test I added got with that call an i136 -> i256 promotion (space for 4 parts) . The updated patch now only creates space for 3 parts, which is also what is expected...

The rest of the cases are expected to be "regular", and the added assert will catch them if they are not...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97514/new/

https://reviews.llvm.org/D97514

Files:
  llvm/lib/Target/SystemZ/SystemZISelLowering.cpp
  llvm/test/CodeGen/SystemZ/args-11.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D97514.326725.patch
Type: text/x-patch
Size: 4589 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210226/b4890c87/attachment.bin>